🩹 make GMP dependency opt-in instead of used-if-found #608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the CMake configuration so that GMP, which can be used in the ZX library, needs to be explicitly added (opt-in) instead of automatically being used (actually unconditionally, without an opt-out option).
This has popped up in cda-tum/mqt-qcec#396 since
delocate
fails to properly repair the produced wheel. This is a result ofgmp
being automatically installed on macOS runners via brew. However, this gets the latest system version, which is not compatible with the minimum macOS targets that we set. I believe this only popped up now, because there has been adelocate
update that catches this.In lack of a better option at the moment, this PR makes GMP support entirely opt-in, which disables it for wheel builds and resolves the underlying issue.
Anyone that wants to build MQT Core with GMP support, can now configure CMake with
-DMQT_CORE_WITH_GMP
In the future, it might be worth investigating whether there is a better way to do this, e.g., by manually building
gmp
with the required compatibility.Checklist: