✨ ship shared C++ libraries with mqt-core Python package #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added
usability
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
=====================================
Coverage 92.0% 92.0%
=====================================
Files 123 125 +2
Lines 13776 13828 +52
Branches 2153 2153
=====================================
+ Hits 12684 12735 +51
- Misses 1092 1093 +1
|
burgholzer
force-pushed
the
shared-libs
branch
2 times, most recently
from
a932c19 to
5382514
Compare
4 tasks
burgholzer
force-pushed
the
shared-libs
branch
5 times, most recently
from
1e105c6 to
34c57c6
Compare
This was referenced Aug 13, 2024
burgholzer
added a commit
that referenced
this pull request
Aug 13, 2024
## Description This PR pulls out a couple of changes from #662 that can go into the library immediately, while that PR is still in draft. Mostly fixes a couple of linter/compiler warnings and improves the handling of Boost / boost_multiprecision. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines.
burgholzer
force-pushed
the
shared-libs
branch
from
34c57c6 to
0f99bcb
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
burgholzer
force-pushed
the
shared-libs
branch
4 times, most recently
from
45e30ba to
56f640f
Compare
burgholzer
force-pushed
the
shared-libs
branch
from
56f640f to
ba6606a
Compare
burgholzer
force-pushed
the
shared-libs
branch
3 times, most recently
from
26df787 to
b15a4ac
Compare
burgholzer
added
major
burgholzer
added a commit
that referenced
this pull request
Sep 28, 2024
## Description This PR updates the CD workflow so that anytime it runs on a push to `main`, it uploads the resulting package to Test PyPI. This allows to battle test the packages before official releases. This will be especially important in the context of #662. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines.
burgholzer
force-pushed
the
shared-libs
branch
3 times, most recently
from
654e252 to
0450f25
Compare
4 tasks
burgholzer
force-pushed
the
shared-libs
branch
4 times, most recently
from
f5e6793 to
ac3a3dc
Compare
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
🚨 ignore check-wheel-contents warnings Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
additionally ignore DLLs in wheels for delvewheel repair. Delvewheel cannot find these by default and would error if this was not set. Signed-off-by: Lukas Burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com> Signed-off-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: burgholzer <burgholzer@me.com>
This is mostly to avoid PyPI space limitations as we typically support all non-EOL Python versions (5) and a total of three emulated platforms. This adds 15 wheels to each release on PyPI, which amounts to over 42% of all wheels (15/35). It also considerably adds to the overall build time. Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
force-pushed
the
shared-libs
branch
from
ac3a3dc to
fdb61f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adapts the
mqt.corePython package to also ship the complete MQT Core C++ library in a compact form so that the Python package can be used as the single source for the C++ and the Python side in top-level projects.In turn, the
mqt-core-pythontarget is (finally) removed, which was long overdue.Top-level projects are now expected to rely on the mqt-core Python package for importing circuits from Qiskit.
To minimise the growth of the mqt-core Python wheels, Python package build will now build shared libraries as opposed to static libraries. The resulting wheels now have a couple megabytes, which should still be reasonable.
However, to minimise the risk of running into space issues on PyPI further, this PR stops building emulated wheels for the
mqt-corePython package. We have no real signs that people are using them in any meaningful way and they take forever to build. Hence, removing them seams like a win-win.Given the potential breaking nature of the discontinuation of the
mqt-core-pythontarget, the next release after this release is merged will bev3.0. I'd expect a couple more breaking changes to come in over the next couple of weeks before that release though.Checklist: