Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Small library improvements #686

Merged
merged 5 commits into from
Sep 6, 2024
Merged

🚸 Small library improvements #686

merged 5 commits into from
Sep 6, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR contains a couple of assorted library improvements including touch ups on the CMake config, the mypy configuration, and the pre-commit hooks.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Sep 6, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file usability Anything related to usability code quality Code quality improvements Core Anything related to the Core library and IR c++ Anything related to C++ code labels Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.1%. Comparing base (1bc7998) to head (8610c9a).
Report is 109 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #686     +/-   ##
=======================================
+ Coverage   86.9%   87.1%   +0.1%     
=======================================
  Files        125     125             
  Lines      13780   13782      +2     
  Branches    2164    2164             
=======================================
+ Hits       11987   12005     +18     
+ Misses      1793    1777     -16     
Flag Coverage Δ
cpp 86.7% <100.0%> (+0.1%) ⬆️
python 99.7% <ø> (ø)
Files with missing lines Coverage Δ
src/circuit_optimizer/CircuitOptimizer.cpp 87.9% <100.0%> (+<0.1%) ⬆️

... and 2 files with indirect coverage changes

@burgholzer burgholzer added this to the MQT Core milestone Sep 6, 2024
@burgholzer burgholzer merged commit 11f7ab0 into main Sep 6, 2024
34 checks passed
@burgholzer burgholzer deleted the small-improvements branch September 6, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code code quality Code quality improvements Core Anything related to the Core library and IR dependencies Pull requests that update a dependency file usability Anything related to usability
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant