Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adopt PEP 735 dependency groups #762

Merged
merged 13 commits into from
Nov 27, 2024
Merged

✨ Adopt PEP 735 dependency groups #762

merged 13 commits into from
Nov 27, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Nov 26, 2024

Description

This PR updates the project to use the dependency groups feature that was proposed in PEP 735 and is available in uv since 0.4.27 in favour of optional dependencies.
It adds three explicit dependency groups:

  • build, containing the build time dependencies,
  • test, containing the test dependencies (including coverage), and
  • docs, containing the docs dependencies.

In addition,

  • enables testing on Python 3.13 (after some dependency adjustments),
  • updates lower bounds for many development dependencies, and
  • refactors the nox sessions to take advantage of the new dependency groups.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Nov 26, 2024
@burgholzer burgholzer added Core Anything related to the Core library and IR python Anything related to Python code packaging Anything related to Python packaging labels Nov 26, 2024
@burgholzer burgholzer added this to the MQT Core milestone Nov 26, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.1%. Comparing base (be0f044) to head (e314f1a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #762   +/-   ##
=====================================
  Coverage   92.1%   92.1%           
=====================================
  Files        125     125           
  Lines      13775   13775           
  Branches    2160    2160           
=====================================
  Hits       12690   12690           
  Misses      1085    1085           
Flag Coverage Δ *Carryforward flag
cpp 91.8% <ø> (ø) Carriedforward from b2a2f74
python 99.7% <100.0%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/mqt/core/__init__.py 100.0% <100.0%> (ø)

@burgholzer burgholzer merged commit 3a28015 into main Nov 27, 2024
30 checks passed
@burgholzer burgholzer deleted the dependency-groups branch November 27, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Anything related to the Core library and IR packaging Anything related to Python packaging python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant