-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor QASM import functionality and remove deprecated formats #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ♻️ turn QASM parser into its own library - 🔥 remove import functionality from `QuantumComputation` the respective functionality is now provided by a separate `MQT::CoreQASM` library - ♻️ refactor QASM parser and improve imports Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
0e6105c
to
5cb74d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
=======================================
+ Coverage 91.8% 92.4% +0.5%
=======================================
Files 129 126 -3
Lines 14157 13257 -900
Branches 2208 2033 -175
=======================================
- Hits 13009 12251 -758
+ Misses 1148 1006 -142
|
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: Lukas Burgholzer <burgholzer@me.com>
4 tasks
burgholzer
added a commit
to cda-tum/mqt-syrec
that referenced
this pull request
Feb 4, 2025
## Description This moves the `.real` parser from MQT Core, where it has been removed in cda-tum/mqt-core#822, to this repository. As there are no previous connection points to the SyReC repository, this is relatively standalone for now. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Anything related to C++ code
code quality
Code quality improvements
Core
Anything related to the Core library and IR
extensive-cpp-ci
Adding this label indicates that extensive C++ CI runs should be started for this PR.
refactor
Anything related to code refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the QASM import functionality by encapsulating the QASM parser into its own dedicated library,
MQT::CoreQASM
. This change removes the import functionality from theQuantumComputation
class, improving modularity and maintainability. Additionally, deprecated formats have been removed, streamlining the codebase.Notably, this removes support for parsing
.real
files. Corresponding support is expected to be integrated into the MQT SyReC Synthesizer at https://github.com/cda-tum/mqt-syrec.Checklist: