DDSIM version of Sampler primitive #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified error message Co-authored-by: Lukas Burgholzer <burgholzer@me.com>
Modified error message Co-authored-by: Lukas Burgholzer <burgholzer@me.com>
Co-authored-by: Lukas Burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
use `assign_parameters` instead of the soon-to-be-deprecated `bind_parameters`. Simplify input validation since many checks are already covered by the `assign_parameters` method in strict mode. Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
3 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
=======================================
+ Coverage 92.5% 92.7% +0.1%
=======================================
Files 32 34 +2
Lines 2540 2586 +46
Branches 349 349
=======================================
+ Hits 2352 2398 +46
Misses 188 188
*This pull request uses carry forward flags. Click here to find out more.
|
burgholzer
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Many thanks again for the changes here. I believe this should be the last iteration before getting this merged.
Besides the inline comments: The docs site for the sampler is currently showing a warning for any circuit drawing. Could you please work around that by explicitly setting the drawing style as suggested by the warning? Please already use the newer style instead of the older fallback.
burgholzer
requested changes
Nov 27, 2023
burgholzer
reviewed
Nov 28, 2023
<!--pre-commit.ci start--> updates: - [github.com/pre-commit/mirrors-clang-format: v17.0.5 → v17.0.6](pre-commit/mirrors-clang-format@v17.0.5...v17.0.6) - [github.com/pre-commit/mirrors-prettier: v3.1.0 → v4.0.0-alpha.3](pre-commit/mirrors-prettier@v3.1.0...v4.0.0-alpha.3) <!--pre-commit.ci end--> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lukas Burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a DDSIM version of one of the qiskit primitives, which is the "Sampler".
Code is inspired in the BackendSampler class from Qiskit https://qiskit.org/documentation/stubs/qiskit.primitives.BackendSampler.html, which in turn is a child class of the more general BaseSampler class https://qiskit.org/documentation/stubs/qiskit.primitives.BaseSampler.html .
This is the second step towards solving issue #295