-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes Required for DD Reordering to Minimize Runtime #407
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: ClaudiaDuenzinger <50296598+Claudiaaaaaaaaa@users.noreply.github.com>
Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: ClaudiaDuenzinger <50296598+Claudiaaaaaaaaa@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=======================================
+ Coverage 92.3% 92.5% +0.1%
=======================================
Files 37 38 +1
Lines 2735 2950 +215
Branches 310 365 +55
=======================================
+ Hits 2527 2730 +203
- Misses 208 220 +12
|
Signed-off-by: ClaudiaDuenzinger <50296598+Claudiaaaaaaaaa@users.noreply.github.com>
Signed-off-by: ClaudiaDuenzinger <50296598+Claudiaaaaaaaaa@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Claudiaaaaaaaaa, many thanks for this PR. Overall it looks very good already, especially, all the test pass already. That is really good. I went through your code in quite some detail and left a couple of comments. At first glance it looks like a lot but some you can just apply by clicking on accept
if you agree. Once again, thank you for your effort. Your work is highly appreciated.
Co-authored-by: Yannick Stade <100073938+ystade@users.noreply.github.com> Signed-off-by: ClaudiaDuenzinger <50296598+Claudiaaaaaaaaa@users.noreply.github.com>
@Claudiaaaaaaaaa Edit: This should hopefully be fixed by #448. Edit 2: apparently, it wasn't fixed 😢 |
(mainly to trigger CI with the new workflows) Signed-off-by: burgholzer <burgholzer@me.com>
Ok, the CI errors should be resolved now. They were due to a regression in the codecov action that would request an OIDC token even from forks (which do not have the right permissions). |
Description
The running time of DDs depends on the order of the nodes in the diagram. In the package DDsim we implement a tool that tries to find the optimal or near-optimal order of nodes resulting in the minimal running time. All changes required in MQT-core are contained in this PR.
Checklist: