Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 drop Python 3.8 support #427

Merged
merged 2 commits into from
Sep 6, 2024
Merged

🔥 drop Python 3.8 support #427

merged 2 commits into from
Sep 6, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Sep 5, 2024

Description

Python 3.8 will reach end of live in October 2024.
Qiskit is already issuing deprecation warnings since a couple of releases when using it on Python 3.8.
This PR officially drops support for Python 3.8 in mqt-ddsim.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Sep 5, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.3%. Comparing base (4409d5d) to head (4c2166a).
Report is 53 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #427   +/-   ##
=====================================
  Coverage   92.3%   92.3%           
=====================================
  Files         37      37           
  Lines       2721    2721           
  Branches     305     305           
=====================================
  Hits        2512    2512           
  Misses       209     209           
Flag Coverage Δ
cpp 94.0% <ø> (ø)
python 87.4% <100.0%> (ø)
Files with missing lines Coverage Δ
src/mqt/ddsim/provider.py 83.3% <100.0%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer force-pushed the drop-python-38-support branch from 6537afd to c1a0aee Compare September 6, 2024 20:25
@burgholzer burgholzer enabled auto-merge (squash) September 6, 2024 22:21
@burgholzer burgholzer merged commit 4b51d54 into main Sep 6, 2024
33 checks passed
@burgholzer burgholzer deleted the drop-python-38-support branch September 6, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant