Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Improved error reporting in HSF and Path Simulator #431

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Sep 12, 2024

Description

This PR improves the error management of the HSF and the Path Simulator and makes them report a little more user-friendly error messages if certain constructs of a circuit are not supported by the simulators.

Fixes #251 and #269

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

makes the simulator support compound operations at the cost of a single circuit traversal

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added documentation Improvements or additions to documentation c++ Anything related to C++ code usability Anything related to usability labels Sep 12, 2024
@burgholzer burgholzer self-assigned this Sep 12, 2024
@burgholzer burgholzer changed the title 🚸 🚸 Improved error reporting in HSF and Path Simulator Sep 12, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.3%. Comparing base (4b51d54) to head (6d6c716).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/HybridSchrodingerFeynmanSimulator.cpp 96.9% 2 Missing ⚠️
include/HybridSchrodingerFeynmanSimulator.hpp 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #431     +/-   ##
=======================================
- Coverage   92.3%   92.3%   -0.1%     
=======================================
  Files         37      37             
  Lines       2720    2732     +12     
  Branches     305     310      +5     
=======================================
+ Hits        2512    2523     +11     
- Misses       208     209      +1     
Flag Coverage Δ
cpp 94.1% <95.6%> (-0.1%) ⬇️
python 87.4% <ø> (ø)
Files with missing lines Coverage Δ
src/PathSimulator.cpp 88.8% <100.0%> (+<0.1%) ⬆️
include/HybridSchrodingerFeynmanSimulator.hpp 60.0% <50.0%> (-0.7%) ⬇️
src/HybridSchrodingerFeynmanSimulator.cpp 97.7% <96.9%> (+0.5%) ⬆️

... and 2 files with indirect coverage changes

@burgholzer burgholzer merged commit 189baa0 into main Sep 12, 2024
33 checks passed
@burgholzer burgholzer deleted the fix-251 branch September 12, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code documentation Improvements or additions to documentation usability Anything related to usability
Projects
Status: Done
Status: Done
1 participant