-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ Refine NALAC tests #470
✅ Refine NALAC tests #470
Conversation
When cda-tum/mqt-core#629 is merged, the reference to MQT-Core must be adopted before merging this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
=======================================
- Coverage 90.4% 90.4% -0.1%
=======================================
Files 86 86
Lines 9975 9982 +7
Branches 1696 1696
=======================================
+ Hits 9020 9025 +5
- Misses 955 957 +2
*This pull request uses carry forward flags. Click here to find out more.
|
What happened here, @lsschmid. The error in the Release run on Linux throws an error in the hybrid mapper. I only renamed |
## Description This PR contains modifications that were necessary for the tests of the Neutral Atom Logical Array Compiler, see cda-tum/mqt-qmap#470. ## Checklist: - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@lsschmid Sorry, I completely looked wrong; the error did not stem from your code at all. 😃 |
@burgholzer I am still looking for the error but having trouble to locate it. So far, I am only running the failing windows test to get faster feedback and have put tons of |
Just quickly commenting here from the phone. Your best guess would probably be a Windows VM in debug mode and a test run started with the debugger attached.. Just depending on standard output is tough with these kinds of errors as they can be swallowed and not really surface, which might pinpoint you to the wrong location. |
Ok. A bit of googling revealed:
So this is not our fault. No need to debug further at the moment. |
This reverts commit 665d6de.
This reverts commit c01dfa3.
This reverts commit 447b278.
This reverts commit cede8f7.
This reverts commit e29fb6d.
This reverts commit b5216fb.
This reverts commit be81273.
This reverts commit 7ea38e1.
This reverts commit 6c77d4f.
This reverts commit 96a0413.
This reverts commit 27d8400.
This reverts commit 0efb310.
This reverts commit 8dd7eb1.
This reverts commit ca320ac.
@burgholzer Tests are still running but should be clean now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Let's ignore the Windows failures for now and get this merged.
Not ideal, since there will be no coverage information, but there isn't that much that we could do 🤷🏼
Description
This PR adds proper tests (and fixes revealed bugs) for the Neutral Atom Logical Array Compiler (NALAC).
Checklist: