-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DD synthesis of irreversible functions (Encoded to reversible without additional line) #115
DD synthesis of irreversible functions (Encoded to reversible without additional line) #115
Conversation
…ange in the comparator function of MinHeapNode struct
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
=====================================
Coverage 92.2% 92.2%
=====================================
Files 32 33 +1
Lines 2233 2287 +54
=====================================
+ Hits 2059 2109 +50
- Misses 174 178 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM. Just a handful suggestions of how to slightly improve this PR.
To be honest I haven't 100% thought through whether this is guaranteed to work. It would be great to have some more tests that ensure it does.
As far as I got it, you are representing a don't care node by having all successors point to the same node. Sounds like a reasonable approach that's fairly easy to check. And I think normalization does not destroy that structure as it just divides every entry by the left-Most maximum value (which is 1).
Please correct me if I got some of that wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not quite satisfied with the structure here. You can find detailed comments down below.
…ity in simulation. Improved testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not happy, but close to.
…ity in simulation. Improved testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope this will be the final one...
Description
This PR addresses the dd synthesis of irreversible functions which are encoded to reversible without any need of an additional line. For the synthesis, don't care conditions must be taken into consideration. This PR introduces the DC node condition based on which the synthesis can be carried forward. Appropriate tests and benchmarks are included as well.
Checklist: