Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified completeCubes function #118

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Conversation

SmaranTum
Copy link
Contributor

@SmaranTum SmaranTum commented Dec 3, 2022

Description

This PR modifies the completeCubes function from a recursive to iterative function.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@SmaranTum SmaranTum requested a review from burgholzer December 3, 2022 23:28
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #118 (4d20966) into main (f6cb1da) will decrease coverage by 0.2%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #118     +/-   ##
=======================================
- Coverage   92.2%   91.9%   -0.3%     
=======================================
  Files         33      33             
  Lines       2287    2296      +9     
=======================================
+ Hits        2109    2112      +3     
- Misses       178     184      +6     
Impacted Files Coverage Δ
src/core/truthTable/truth_table.cpp 90.6% <100.0%> (-0.3%) ⬇️
include/core/properties.hpp 44.4% <0.0%> (-5.6%) ⬇️
include/core/truthTable/truth_table.hpp 94.6% <0.0%> (-3.2%) ⬇️
src/core/syrec/parser.cpp 83.6% <0.0%> (-0.2%) ⬇️
include/core/syrec/grammar.hpp 97.0% <0.0%> (-0.2%) ⬇️
include/core/syrec/statement.hpp 95.3% <0.0%> (-0.1%) ⬇️
...lgorithms/synthesis/syrec_line_aware_synthesis.cpp 95.1% <0.0%> (-0.1%) ⬇️
include/core/gate.hpp 20.0% <0.0%> (ø)
include/core/syrec/parser.hpp 100.0% <0.0%> (ø)
include/core/syrec/program.hpp 100.0% <0.0%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgholzer burgholzer enabled auto-merge (squash) December 3, 2022 23:42
@burgholzer burgholzer merged commit 296e8ff into cda-tum:main Dec 3, 2022
@SmaranTum SmaranTum deleted the completeCubes branch December 12, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants