🚸 improve coverage data collection #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added
continuous integration
4 tasks
this is to ensure that the codecov configuration is present
|
Seems to be working: cda-tum/mqt-core#612 |
burgholzer
added a commit
to cda-tum/mqt-core
that referenced
this pull request
May 25, 2024
## Description This PR experiments with the new coverage collection workflow proposed in cda-tum/mqt-workflows#2. The workflow now aggregates all coverage reports on the GitHub side before uploading to Codecov. It also uses Codecov's OIDC instead of TOKEN upload. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves how coverage data is collected and uploaded to codecov. Since we upload quite a couple of reports, the codecov CI was frequently failing, especially on PRs from forks.
This PR changes the workflows so that they first upload all Python coverage reports as artifacts, which are then collected and uploaded in one go.
Furthermore, this PR switches to using OIDC instead of
CODECOV_TOKENwhich eliminates the need for storing the codecov token as a repository secret.An added benefit of this approach is that there is only one Python coverage upload; independent from the number of jobs and Python versions. Thus, the same coverage configuration can be used in all projects.
Before merging, this PR needs testing in at least one of the upstream repositories.