Expose the jclouds core classes to consumers of this library #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martinda looks good to me. Should we do the same with the other *-rest libraries as well? |
|
@cdancy I am studying the situation by locally applying this dependency analysis plugin: https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/ I cannot say that I understand or agree with everything that it tells me. To answer your question, I need to review the APIs more closely, but if that's the same case as here then yes. |
|
I visually reviewed the APIs and this change appears to cover all of it for this rest library. Please merge when you are ready. I'm going to check the others now. |
|
For jenkins-rest: it does not expose the API of its dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #87 . The
PayloadAPI was introduced way back in e37bde7 . I also fixed the javadoc link to include thejclouds-coreclasses by pointing to the javadoc.io website.