Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(project): go-style v2 to pythonic v3 #11

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Conversation

cdddg
Copy link
Owner

@cdddg cdddg commented Aug 15, 2023

In April 2023, I released version v2 of the project. Reflecting upon it, I recognized a strong influence of Go-specific styles in its structure. With this PR, I aim to refine the project's architecture, transitioning from the Go-centric design to one that aligns more closely with conventional Python practices.


Changelog:

  • Top-level Directory:
    • Renamed: srcapp
    • Moved: corecommon
  • Module Adjustments:
    • Moved: core/exception.pymodels/exception.py
    • Relocated:
      • settings/dependency_injection.pyapp/di/dependency_injection.py
      • settings/unit_of_work.pyapp/di/unit_of_work.py
  • Spelling & Directory Corrections:
    • Renamed: src/deliveries/graphql/pokomonapp/deliveries/graphql/pokemon

Original Structure (v2):

src/
├── core/
│   ├── exception.py
│   └── ...
├── deliveries/
│   ├── graphql/
│   │   └── pokomon/  # Note the misspelling here
│   │       └── ...
│   └── ...
├── settings/
│   ├── dependency_injection.py
│   ├── unit_of_work.py
│   └── ...
└── ...

Updated Structure (v3):

src/
├── app/
│   ├── deliveries/
│   │   ├── graphql/
│   │   │   └── pokemon/  # Spelling corrected
│   │   │       └── ...
│   │   └── ...
│   ├── di/
│   │   ├── dependency_injection.py
│   │   └── unit_of_work.py
│   └── ...
├── common/
│   └── ...
├── models/
│   ├── exception.py
│   └── ...
└── ...

@cdddg cdddg changed the title refactor(project): Go-style v2 to Pythonic v3 refactor(project): go-style v2 to pythonic v3 Aug 15, 2023
@cdddg cdddg force-pushed the refactor-project-2 branch 5 times, most recently from e45786e to 1a75aa6 Compare August 16, 2023 02:33
@cdddg cdddg merged commit c80ec98 into master Aug 16, 2023
@cdddg cdddg deleted the refactor-project-2 branch August 19, 2023 03:02
cdddg added a commit that referenced this pull request Oct 11, 2024
* refactor(project): go-style v2 to pythonic v3

* fix: typo

* fix: style

* fix: remove unused

* chore(package): update main and dev and test packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant