Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving over to crypton backend #81

Merged
merged 8 commits into from
Oct 19, 2024
Merged

Moving over to crypton backend #81

merged 8 commits into from
Oct 19, 2024

Conversation

Vlix
Copy link
Collaborator

@Vlix Vlix commented Jul 6, 2024

Also updated a bit of the CI settings, since we got GHC 9.6.6 now.
And the haskell/actions/setup is now deprecated, using haskell-actions/setup now.

@Vlix Vlix requested a review from cdepillabout July 6, 2024 22:45
@Vlix
Copy link
Collaborator Author

Vlix commented Jul 6, 2024

#78

cdepillabout
cdepillabout approved these changes Jul 15, 2024
View reviewed changes
Copy link
Owner

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

If we know the OSX GitHub Actions fail, we could always just remove them as well. No sense in keeping them around if we always just ignore them.

@Vlix
Copy link
Collaborator Author

Vlix commented Jul 15, 2024 •
edited
Loading

I'd like the OSX actions to just work, so I don't want to remove them... but I didn't have time to actually look into it. :/

EDIT: It's mostly the scrypt package, it seems. (Except GHC 9.0.2, there it's something about LLVM that's erroring)
Maybe we should remove the scrypt test we have in there (was a regressions test when going from password-1.0.0.0 to password-2.0.0.0. 🤔

@Vlix Vlix merged commit a17a93c into cdepillabout:master Oct 19, 2024
@Vlix Vlix deleted the moving-over-to-crypton-backend branch October 19, 2024 06:21
@Vlix
Copy link
Collaborator Author

Vlix commented Oct 19, 2024

@cdepillabout version 3.1.0.0 is now pushed to hackage, ready for nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlix @cdepillabout