Embed the schemas in generated files #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go:embed includes files at build time into a binary. It doesn't work when consuming the SDK as a go module, since the json files are not included in the module itself. Instead of using embed, load the json file into the template file and embed it directly (at generate time) into the generated go files. Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go:embed includes files at build time into a binary. It doesn't work when consuming the SDK as a go module, since the json files are not included in the module itself.
Instead of using embed, load the json file into the template file and embed it directly (at generate time) into the generated go files.