fix: export 406 and rename 413 (#448)

* Export NotAcceptable error type * Rename RequestEntityTooLarge error type
cdimascio · Nov 7, 2020 · 0f48f1f · 0f48f1f
1 parent 80ca68f
commit 0f48f1f
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 14 deletions.
diff --git a/src/framework/types.ts b/src/framework/types.ts
@@ -521,7 +521,7 @@ export class HttpError extends Error implements ValidationError {
   }):
     | InternalServerError
     | UnsupportedMediaType
-    | RequestEntityToLarge
+    | RequestEntityTooLarge
     | BadRequest
     | MethodNotAllowed
     | NotAcceptable
@@ -542,7 +542,7 @@ export class HttpError extends Error implements ValidationError {
       case 406:
         return new NotAcceptable(err);
       case 413:
-        return new RequestEntityToLarge(err);
+        return new RequestEntityTooLarge(err);
       case 415:
         return new UnsupportedMediaType(err);
       default:
@@ -613,7 +613,7 @@ export class BadRequest extends HttpError {
   }
 }
 
-export class RequestEntityToLarge extends HttpError {
+export class RequestEntityTooLarge extends HttpError {
   constructor(err: {
     path: string;
     message?: string;

diff --git a/src/index.ts b/src/index.ts
@@ -5,9 +5,10 @@ import { OpenApiSpecLoader } from './framework/openapi.spec.loader';
 import {
   InternalServerError,
   UnsupportedMediaType,
-  RequestEntityToLarge,
+  RequestEntityTooLarge,
   BadRequest,
   MethodNotAllowed,
+  NotAcceptable,
   NotFound,
   Unauthorized,
   Forbidden,
@@ -19,9 +20,10 @@ export const middleware = openapiValidator;
 export const error = {
   InternalServerError,
   UnsupportedMediaType,
-  RequestEntityToLarge,
+  RequestEntityTooLarge,
   BadRequest,
   MethodNotAllowed,
+  NotAcceptable,
   NotFound,
   Unauthorized,
   Forbidden,

diff --git a/src/middlewares/openapi.multipart.ts b/src/middlewares/openapi.multipart.ts
@@ -125,7 +125,7 @@ function error(req: OpenApiRequest, err: Error): ValidationError {
       message: err.message,
     });
     /*return payload_too_big
-      ? new RequestEntityToLarge({ path: req.path, message: err.message })
+      ? new RequestEntityTooLarge({ path: req.path, message: err.message })
       : !unexpected
       ? new BadRequest({ path: req.path, message: err.message })
       : new InternalServerError({ path: req.path, message: err.message });*/

diff --git a/src/openapi.validator.ts b/src/openapi.validator.ts
@@ -24,9 +24,10 @@ export {
   OpenApiValidatorOpts,
   InternalServerError,
   UnsupportedMediaType,
-  RequestEntityToLarge,
+  RequestEntityTooLarge,
   BadRequest,
   MethodNotAllowed,
+  NotAcceptable,
   NotFound,
   Unauthorized,
   Forbidden,

diff --git a/test/httperror.spec.ts b/test/httperror.spec.ts
@@ -62,21 +62,21 @@ describe(packageJson.name, () => {
     done();
   });
 
-  it('should be an instance of RequestEntityToLarge', (done) => {
-    console.log('Testing instaceof detection of RequestEntityToLarge');
+  it('should be an instance of RequestEntityTooLarge', (done) => {
+    console.log('Testing instaceof detection of RequestEntityTooLarge');
     const err = {
-      path: '/entity_to_large',
-      message: 'request qntity too large',
+      path: '/entity_too_large',
+      message: 'request entity too large',
     };
-    expect(new error.RequestEntityToLarge(err)).to.be.an.instanceof(
-      error.RequestEntityToLarge,
+    expect(new error.RequestEntityTooLarge(err)).to.be.an.instanceof(
+      error.RequestEntityTooLarge,
     );
     expect(
       HttpError.create({
         status: 413,
         ...err,
       }),
-    ).to.be.an.instanceof(error.RequestEntityToLarge);
+    ).to.be.an.instanceof(error.RequestEntityTooLarge);
     done();
   });