Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileUploader doesn't fully replace multerOpts #222

Closed
JacobLey opened this issue Jan 16, 2020 · 1 comment
Closed

fileUploader doesn't fully replace multerOpts #222

JacobLey opened this issue Jan 16, 2020 · 1 comment

Comments

@JacobLey
Copy link
Collaborator

Hello,

I think I've run into an issue regarding the change from multerOpts to fileUploader.

https://github.com/cdimascio/express-openapi-validator/pull/205/files
With the recent version 3.6.3 when I provide multerOpts (unchanged usage, but according to README it is acceptable for now) files get cached locally instead of forwarded onto the provided storage (I was providing a storage attribute, but thats getting farther into multer's settings).

I tried changing the variable name to fileUploader but still behavior is not desired.

Looking through the code, its looks like my issue comes from this line: https://github.com/cdimascio/express-openapi-validator/blob/master/src/index.ts#L153

Essentially I think multerOpts should be replaced with fileUploader to match the rest of the logic: https://github.com/cdimascio/express-openapi-validator/blob/master/src/index.ts#L153

Does that make sense?
Opened a PR to help highlight the issue and hopefully fix: #221

@cdimascio
Copy link
Owner

thanks for the ticket and the fix. merged in 3.6.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants