Update deprecated multerOpts reference, update test #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g properly passed to multer
JacobLey
commented
Jan 16, 2020
| })); | ||
|
|
||
| }); | ||
| expect(fileNames).to.deep.equal(['package.json']); |
There was a problem hiding this comment.
Not sure what the best pattern here is (e.g. should fileNames really be unchanged on all tests, and cleared before each? Or maybe it somehow only exists in this test?)
The "filter" function just seemed like an easy way to check that multer is actually receiving the options + file
There was a problem hiding this comment.
this is fine for now. i don't have better idea atm. we can improve the test later if needed
cdimascio
approved these changes
Jan 16, 2020
| })); | ||
|
|
||
| }); | ||
| expect(fileNames).to.deep.equal(['package.json']); |
There was a problem hiding this comment.
this is fine for now. i don't have better idea atm. we can improve the test later if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding failing test first. Will follow up with fix + link to issue