Default values missing in query

[xeoneux]

First of all, thanks a lot for this package @cdimascio

I couldn't find any other lib that handles OpenAPI v3 well, is well maintained and has a good amount of tests 😄

So here's my issue:
For example, I'm using this schema:

Sort:
      properties:
        field:
          default: id
          enum:
            - id
          type: string
        order:
          default: ASC
          enum:
            - ASC
            - DESC
          type: string
      type: object

Along with this query item:

parameters:
        - in: query
          name: sort
          required: false
          schema:
            $ref: '#/components/schemas/Sort'
          style: deepObject

Then, inside the route, the req.query.sort is an empty object instead of the default values, { sort: {field: 'id', order: 'ASC'} }

Is the not the desired behaviour or is it because of the deepObject style?

[cdimascio]

Thanks for the issue @xeoneux. I created 2 new tests for deepObject that use default values. The tests are similar to your use case. They appear to work.

Here are some links

tests:

• https://github.com/cdimascio/express-openapi-validator/blob/master/test/serialized.objects.spec.ts#L138
• https://github.com/cdimascio/express-openapi-validator/blob/master/test/serialized.objects.spec.ts#L138

spec:

• https://github.com/cdimascio/express-openapi-validator/blob/master/test/resources/serialized.objects.yaml#L11

• https://github.com/cdimascio/express-openapi-validator/blob/master/test/resources/serialized.objects.yaml#L41

Please have a look at the tests. As I noted they work. I could use some help reproducing your case. If you can create a test that demonstrates the issue, I'll certainly take a look. Thanks.

Note, you can click the Gitpod link at the top right of this page (or the Gitpod link on the README) to get a full dev environment setup for this project. Once it completes, you can run the two tests to poke around (see CONTRIBUTING.MD for details on running tests).

[xeoneux]

Hi @cdimascio, I created a repo for the case here: https://github.com/xeoneux/express-openapi-validator-default-query-issue

I'm using $ref for schema to query object and I can see your test as well for that deep_object_2 but it's not working for this case.

[cdimascio]

@xeoneux Thanks for the sample. I'm working on a fix. Should have something soon

[cdimascio]

@xeoneux please give version 3.12.8 a try. The issue should be resolved there

[xeoneux]

Sure, will you create a release on npm please?

[cdimascio]

Yes. Its already available. Let me know how it goes

[xeoneux]

Works perfectly fine! Thanks @cdimascio 😄