-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serdes Does Not Work for Items in Object in Array #699
Serdes Does Not Work for Items in Object in Array #699
Comments
@YaakovR thanks so much for this issue. You isolated the issue I was having deep in a structure and made it much easier to find. I believe I have a fix with a test that I'll submit as a PR. |
Did this PR ever make it through? I think I'm having that issue myself now. |
@Jackman3005 No it did not. @cdimascio Can we get #704 reviewed and merged now? |
@robertjustjones +1 |
I've spent several days digging to the root cause by facing the same issue and happily found that there is a PR already, thank you @robertjustjones Gentlemen, when do you think this can be fixed? |
We are waiting for the approve of the repository owner |
@cdimascio Are there any hints about when a release with this fix will be rolled out? |
This is now available in v5.0.0 |
Describe the bug
Serdes performs well on properties in an object. However, when the owning object is part of an array, then
serialize
is never called.To Reproduce
git clone https://github.com/cdimascio/express-openapi-validator.git
npm run deps && npm i
cd express-openapi-validator/examples/7-response-date-serialization
npm start
GET http://localhost:3000/v1/date-time
The above works fine.
Let's now modify the route in
app.js
to return an array of objects:We'll also modify the schema in
api.yaml
:Actual behavior
Expected behavior
The text was updated successfully, but these errors were encountered: