Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not coerce request body property values #387

Merged
merged 6 commits into from
Oct 4, 2020
Merged

Conversation

cdimascio
Copy link
Owner

@cdimascio cdimascio commented Oct 4, 2020

This PR remove type coercion from request bodies.
This should fix the following issues:

@MadMango
Copy link
Contributor

I just found this issue after upgrading the library and finding that it's broken because I'm sending numbers as strings to our APIs.

There are good reasons to have coercion enabled as explained here

@cdimascio What was the rationale behind removing the option completely? The problem you references could have been solved by just setting coerceTypes to false.

@cdimascio
Copy link
Owner Author

Thanks for your input. Here is the rationale. Happy to open the discussion.
#396 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants