Name middleware #583
Merged
Name middleware #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdimascio
requested changes
Apr 20, 2021
|
@benblack86 thanks! |
|
Updated |
cdimascio
reviewed
Apr 22, 2021
src/openapi.validator.ts
Outdated
| let inited = false; | ||
| // install path params | ||
| middlewares.push((req, res, next) => | ||
| pContext | ||
| middlewares.push(function PathParamsMiddleware(req, res, next) { |
There was a problem hiding this comment.
one more nit. use lower case camelCase for the function names e.g. pathParamsMiddleware. apologies for not being clear with my first comment
|
Updated |
crudo
pushed a commit
to crudo/express-openapi-validator
that referenced
this pull request
Aug 17, 2021
* Name middleware * Fix this * Add comment * Updates * Lowercase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tracing, anonymous functions wouldn't show up with name. I've converted these anonymous functions to named functions so it is a little more clearer what is happening. Let me know if you think a different naming schema would be better.