Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#671 default export in handler #675

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

zzgab
Copy link
Contributor

@zzgab zzgab commented Nov 28, 2021

Hi,

issue #671

I wasn't sure whether to add the x-eov-operation-handler optional property in OperationObject interface (since it has an important meaning in the program).

If you think it does not belong, we could instead use a // @ts-ignore comment in my new test before line 21.

Thanks

@cdimascio
Copy link
Owner

@zzgab thanks. This looks good. Please add the tsignore and I’ll get this merged

@zzgab
Copy link
Contributor Author

zzgab commented Nov 29, 2021

Updated.
Thanks.

@cdimascio cdimascio merged commit e68a604 into cdimascio:master Nov 29, 2021
@cdimascio
Copy link
Owner

this fix is in 4.13.4. thanks again

@cdimascio
Copy link
Owner

@all-contributors add @zzgab for code and test

@allcontributors
Copy link
Contributor

@cdimascio

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token } in JSON at position 12755

@zzgab zzgab deleted the default_export branch November 29, 2021 21:49
@zzgab
Copy link
Contributor Author

zzgab commented Nov 30, 2021

@cdimascio for all it's worth, I've fixed this JSON file here #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants