Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make ingress extensible #4828

Open
wants to merge 2 commits into
base: k8s-31/main
Choose a base branch
from

Conversation

eminugurkenar
Copy link

@eminugurkenar eminugurkenar commented Oct 21, 2024

in order to extend Ingress object for custom needs implemented couple of changes

  • for some ingress classes sorting paths is not something you would want , for instance ALB ingress controller , because order matters while evaluating the rules, so i think we can provide a prop to get sorting function from outside of lib.

  • IngressBackend constructor should be public in order to extend it , sometimes you need to add extra functionally, like for ALB ingress controller , 'use-annotation'

https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.2/guide/ingress/annotations/

alb.ingress.kubernetes.io/actions.${action-name} Provides a method for configuring custom actions on a listener, such as Redirect Actions.

The action-name in the annotation must match the serviceName in the Ingress rules, and servicePort must be use-annotation.`

@eminugurkenar eminugurkenar changed the title make ingress extensible feat: make ingress extensible Oct 21, 2024
Signed-off-by: ugurkenar <eminugurkenar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant