Skip to content

Commit

Permalink
fix(defaults): Change default image to reflect new jsii image tags (#…
Browse files Browse the repository at this point in the history
…1127)

The 'latest' tag has been discontinued for the jsii/superchain image (documented [here](https://hub.docker.com/r/jsii/superchain)). This change updates the default image from 'latest' to the recommended replacement, '1-buster-slim'

Closes #1114 

-----

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • Loading branch information
biffgaut authored May 20, 2022
1 parent 0a0af31 commit 76e7975
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions lib/__tests__/expected.yml
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ Resources:
- Name: DELIVLIB_ENV_TEST
Type: PLAINTEXT
Value: MAGIC_1924
Image: jsii/superchain:latest
Image: jsii/superchain:1-buster-slim
ImagePullCredentialsType: SERVICE_ROLE
PrivilegedMode: false
Type: LINUX_CONTAINER
Expand Down Expand Up @@ -3707,7 +3707,7 @@ Resources:
Type: NO_ARTIFACTS
Environment:
ComputeType: BUILD_GENERAL1_SMALL
Image: jsii/superchain:latest
Image: jsii/superchain:1-buster-slim
ImagePullCredentialsType: SERVICE_ROLE
PrivilegedMode: false
Type: LINUX_CONTAINER
Expand Down Expand Up @@ -3837,7 +3837,7 @@ Resources:
Type: NO_ARTIFACTS
Environment:
ComputeType: BUILD_GENERAL1_SMALL
Image: jsii/superchain:latest
Image: jsii/superchain:1-buster-slim
ImagePullCredentialsType: SERVICE_ROLE
PrivilegedMode: false
Type: LINUX_CONTAINER
Expand Down
2 changes: 1 addition & 1 deletion lib/build-env.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export function createBuildEnvironment(props: BuildEnvironmentProps) {
computeType: props.computeType || cbuild.ComputeType.SMALL,
privileged: props.privileged,
environmentVariables: renderEnvironmentVariables({ ...props.environment, ...props.env }),
buildImage: props.buildImage || cbuild.LinuxBuildImage.fromDockerRegistry('jsii/superchain:latest'),
buildImage: props.buildImage || cbuild.LinuxBuildImage.fromDockerRegistry('jsii/superchain:1-buster-slim'),
};

return environment;
Expand Down

0 comments on commit 76e7975

Please sign in to comment.