chore: upgrade to SDK v3 #1709
Merged
chore: upgrade to SDK v3 #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comcalvi
changed the title
scanlonp
approved these changes
Jul 25, 2024
Comment on lines
+2
to
+6
|
|
||
|
|
||
| // eslint-disable-next-line import/no-extraneous-dependencies | ||
| import { CodePipeline } from '@aws-sdk/client-codepipeline'; | ||
| const pipeline = new CodePipeline(); |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line import/no-extraneous-dependencies | |
| import { CodePipeline } from '@aws-sdk/client-codepipeline'; | |
| const pipeline = new CodePipeline(); | |
| import { CodePipeline } from '@aws-sdk/client-codepipeline'; | |
| const pipeline = new CodePipeline(); |
formatting clean up
There was a problem hiding this comment.
Why do you think the comment line // eslint-disable-next-line import/no-extraneous-dependencies is there?
There was a problem hiding this comment.
The suggester wouldn't let me highlight line 1. It's duplicated there.
Comment on lines
+2
to
+5
|
|
||
|
|
||
| // eslint-disable-next-line import/no-extraneous-dependencies | ||
| import { S3 } from '@aws-sdk/client-s3'; |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line import/no-extraneous-dependencies | |
| import { S3 } from '@aws-sdk/client-s3'; | |
| import { S3 } from '@aws-sdk/client-s3'; |
formatting clean up
Comment on lines
+2
to
+5
|
|
||
|
|
||
| // eslint-disable-next-line import/no-extraneous-dependencies | ||
| import { CloudWatch, Dimension, PutMetricDataCommandInput } from '@aws-sdk/client-cloudwatch'; |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line import/no-extraneous-dependencies | |
| import { CloudWatch, Dimension, PutMetricDataCommandInput } from '@aws-sdk/client-cloudwatch'; | |
| import { CloudWatch, Dimension, PutMetricDataCommandInput } from '@aws-sdk/client-cloudwatch'; |
formatting clean up
scanlonp
added
the
do-not-merge
rix0rrr
removed
the
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1706, which upgraded the node runtimes to 20. Node 20 is only compatible with SDK v3. This removes every use of the SDK v2.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.