fix(gpg resource): survive errors during cleanup #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the GPG agent is shutdown, it removes some UNIX sockets from the temporary directory. Their removal may race with the `rmrf` that we run in the custom resource, leading to an `ENOENT` error. Catch it and continue.
rix0rrr
changed the title
mrgrain
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the GPG agent is shutdown, it removes some UNIX sockets from the temporary directory. Their removal may race with the
rmrfthat we run in the custom resource, leading to anENOENTerror.Catch it and continue. Ultimately, this code runs in a Lambda and all files are going to disappear anyway.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.