feat: Allow update of PGPSecret and PrivateKey #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the python code that backs the custom resource implementations for the PGPSecret and PrivateKey constructs so they allow updating the KMS encryption keys used by AWS SecretsManager without necessarily re-generating new secrets. Also, added a `resourceVersion` has to the properties so the resource handler is called again if the implementation code changed. BREAKING CHANGE: this also changes the API of the PGPSecret and CodeSigningCertificate constructs to offer a consistent API for accessing the name and ARNs of the secret and parameters associated with the secrets, through the `ICredentialPair` interface.
eladb
reviewed
Dec 18, 2018
This was referenced Dec 19, 2018
eladb
reviewed
Dec 23, 2018
eladb
approved these changes
Dec 27, 2018
justnance
added
feature-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the python code that backs the custom resource implementations for the
PGPSecret and PrivateKey constructs so they allow updating the KMS encryption
keys used by AWS SecretsManager without necessarily re-generating new secrets.
Also, added a
resourceVersionhas to the properties so the resource handler iscalled again if the implementation code changed.
BREAKING CHANGE: this also changes the API of the PGPSecret and
CodeSigningCertificate constructs to offer a consistent API for accessing the name
and ARNs of the secret and parameters associated with the secrets, through the
ICredentialPairinterface.