Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KubectLayer and release as @aws-cdk/lambda-layer-kubectl-v28 #450

Merged
merged 2 commits into from
Oct 26, 2023
Merged

feat: add KubectLayer and release as @aws-cdk/lambda-layer-kubectl-v28 #450

merged 2 commits into from
Oct 26, 2023

Conversation

mperochon
Copy link

Fixes #437

@gkaskonas
Copy link
Contributor

Is it normal for the build to take 2 days?

@mperochon
Copy link
Author

Is it normal for the build to take 2 days?

It needs an approval by the maintainer

@mperochon
Copy link
Author

Just a little followup for @pahud @kaizencc

@gkaskonas
Copy link
Contributor

@pahud @kaizencc Sorry guys, can you approve, please? It's blocking us from upgrading

@caretak3r
Copy link

Can we migrate this project to cdk where we have active maintainers? Plus the documentation is unclear about how to use this in a python project.

@pahud
Copy link
Contributor

pahud commented Oct 25, 2023

Thank you @mperochon !! The build is pending for approval to run and I just hit it. Hopefully everything works great here.

After this PR is merged, we can advance aws/aws-cdk#27502 to get 1.28 supported.

@pahud
Copy link
Contributor

pahud commented Oct 25, 2023

Hi @mperochon

I guess you'll need to run yarn install && npx projen again to update the yarn.lock and commit again.

Feel free to reach out and chat with me on cdk.dev slack if you need any help.

@mperochon
Copy link
Author

Hi @pahud,

You're welcome, I'm just push the commit with the yarn.lock change.

Let me know if you need anything else

@pahud pahud requested a review from dougalrea October 26, 2023 16:38
@mergify mergify bot merged commit 3ddaa84 into cdklabs:kubectl-v28/main Oct 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants