fix(all): a single allowed value causes failure #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are checking for the second value of allowed values first when checking for booleans. This causes a failure when only one allowed value is provided for a parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are checking for the second value of allowed values first when checking for booleans. This causes a failure when only one allowed value is provided for a parameter.
This PR includes the template that is being tested against but not the test cases because there are still other failures. The next PR will include the test cases and a fix for the bug preventing a successful run.
Fixes part of aws/aws-cdk#29752
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.