fix: Add the environment attribute to workflow yml file conditionally (…

…#186) Based on discussion #178 (comment) Removes `environment: null` from workflows that did not specify the environment.
cdklabs · Apr 29, 2022 · 0e29c2b · 0e29c2b
1 parent 71346e6
commit 0e29c2b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/pipeline.ts b/src/pipeline.ts
@@ -461,7 +461,9 @@ export class GitHubWorkflow extends PipelineBase {
           contents: github.JobPermission.READ,
           idToken: this.useGitHubActionRole ? github.JobPermission.WRITE : github.JobPermission.NONE,
         },
-        environment: this.stackEnvs[stack.stackArtifactId],
+        ...(this.stackEnvs[stack.stackArtifactId] ? {
+          environment: this.stackEnvs[stack.stackArtifactId],
+        } : {}),
         needs: this.renderDependencies(node),
         runsOn: this.runner.runsOn,
         steps: [

diff --git a/test/__snapshots__/github.test.ts.snap b/test/__snapshots__/github.test.ts.snap