fix: decouple workflowNodeVersion from minNodeVersion
#610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`workflowNodeVersion` is copied from `minNodeVersion` if not set. This incentivizes undesirable behavior: `minNodeVersion` should almost never need to be set, while `workflowNodeVersion` might need to be set. As a result, users might set `minNodeVersion` while looking for the other version. Fix that in the types that wrap projen types here, in preparation of an upstream projen fix.
Signed-off-by: github-actions <github-actions@github.com>
…s-projen-project-types into huijbers/min-node-version
Signed-off-by: github-actions <github-actions@github.com>
mrgrain
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflowNodeVersionis copied fromminNodeVersionif not set.This incentivizes undesirable behavior:
minNodeVersionshould almost never need to be set, whileworkflowNodeVersionmight need to be set.As a result, users might set
minNodeVersionwhile looking for the other version.Fix that in the types that wrap projen types here, in preparation of an upstream projen fix.
Default workflow versions to
lts/*, this is almost always what you want anyway.