Skip to content

Commit

Permalink
fix: drop engine requirement (#59)
Browse files Browse the repository at this point in the history
Previous versions of this library would fail to install on older Node 18's, like Node 18.17.

That's because `minNodeVersion` was set, whereas probably the intent was to set `workflowNodeVersion`.
  • Loading branch information
rix0rrr authored Sep 18, 2024
1 parent 1bd4453 commit 10869f2
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 18 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/build.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions .github/workflows/release.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/upgrade-main.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,12 @@ export const project = new cdk.JsiiProject({
keywords: ['aws', 'cdk'],
repositoryUrl: 'https://github.com/cdklabs/cloud-assembly-schema.git',
homepage: 'https://github.com/cdklabs/cloud-assembly-schema',
minNodeVersion: '18.18.0',
// Don't set minNodeVersion -- this is just a library with some data and a
// couple of simple JS files. It doesn't care about the Node version of the
// consuming party at all. It's unlikely you will try to install this on a
// Node version it doesn't work on.
// minNodeVersion: '18.18.0',
workflowNodeVersion: 'lts/*',
excludeTypescript: ['**/test/**/*.ts'],
publishToMaven: {
javaPackage: 'software.amazon.awscdk.cloudassembly.schema',
Expand Down
3 changes: 0 additions & 3 deletions package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 10869f2

Please sign in to comment.