forked from apache/hudi
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[HUDI-4038] Avoid calling
getDataSize after every record written (a…
…pache#5497) - getDataSize has non-trivial overhead in the current ParquetWriter impl, requiring traversal of already composed Column Groups in memory. Instead we can sample these calls to getDataSize to amortize its cost. Co-authored-by: sivabalan <n.siva.b@gmail.com>
- Loading branch information
1 parent
daaa170
commit 0bd4539
Showing
12 changed files
with
124 additions
and
97 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
.../hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieBaseParquetWriter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hudi.io.storage; | ||
|
|
||
| import org.apache.hadoop.fs.Path; | ||
| import org.apache.hudi.common.fs.FSUtils; | ||
| import org.apache.hudi.common.fs.HoodieWrapperFileSystem; | ||
| import org.apache.parquet.hadoop.ParquetFileWriter; | ||
| import org.apache.parquet.hadoop.ParquetWriter; | ||
| import org.apache.parquet.hadoop.api.WriteSupport; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.concurrent.atomic.AtomicLong; | ||
|
|
||
| /** | ||
| * Base class of Hudi's custom {@link ParquetWriter} implementations | ||
| * | ||
| * @param <R> target type of the object being written into Parquet files (for ex, | ||
| * {@code IndexedRecord}, {@code InternalRow}) | ||
| */ | ||
| public abstract class HoodieBaseParquetWriter<R> extends ParquetWriter<R> { | ||
|
|
||
| private static final int WRITTEN_RECORDS_THRESHOLD_FOR_FILE_SIZE_CHECK = 1000; | ||
|
|
||
| private final AtomicLong writtenRecordCount = new AtomicLong(0); | ||
| private final long maxFileSize; | ||
| private long lastCachedDataSize = -1; | ||
|
|
||
| public HoodieBaseParquetWriter(Path file, | ||
| HoodieBaseParquetConfig<? extends WriteSupport<R>> parquetConfig) throws IOException { | ||
| super(HoodieWrapperFileSystem.convertToHoodiePath(file, parquetConfig.getHadoopConf()), | ||
| ParquetFileWriter.Mode.CREATE, | ||
| parquetConfig.getWriteSupport(), | ||
| parquetConfig.getCompressionCodecName(), | ||
| parquetConfig.getBlockSize(), | ||
| parquetConfig.getPageSize(), | ||
| parquetConfig.getPageSize(), | ||
| parquetConfig.dictionaryEnabled(), | ||
| DEFAULT_IS_VALIDATING_ENABLED, | ||
| DEFAULT_WRITER_VERSION, | ||
| FSUtils.registerFileSystem(file, parquetConfig.getHadoopConf())); | ||
|
|
||
| // We cannot accurately measure the snappy compressed output file size. We are choosing a | ||
| // conservative 10% | ||
| // TODO - compute this compression ratio dynamically by looking at the bytes written to the | ||
| // stream and the actual file size reported by HDFS | ||
| this.maxFileSize = parquetConfig.getMaxFileSize() | ||
| + Math.round(parquetConfig.getMaxFileSize() * parquetConfig.getCompressionRatio()); | ||
| } | ||
|
|
||
| public boolean canWrite() { | ||
| // TODO we can actually do evaluation more accurately: | ||
| // if we cache last data size check, since we account for how many records | ||
| // were written we can accurately project avg record size, and therefore | ||
| // estimate how many more records we can write before cut off | ||
| if (lastCachedDataSize == -1 || getWrittenRecordCount() % WRITTEN_RECORDS_THRESHOLD_FOR_FILE_SIZE_CHECK == 0) { | ||
| lastCachedDataSize = getDataSize(); | ||
| } | ||
| return lastCachedDataSize < maxFileSize; | ||
| } | ||
|
|
||
| @Override | ||
| public void write(R object) throws IOException { | ||
| super.write(object); | ||
| writtenRecordCount.incrementAndGet(); | ||
| } | ||
|
|
||
| protected long getWrittenRecordCount() { | ||
| return writtenRecordCount.get(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters