[HUDI-4055]refactor ratelimiter to avoid stack overflow (apache#5530)

cdmikechen · May 13, 2022 · fb65e19 · fb65e19
1 parent 82c22b3
commit fb65e19
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/hudi-common/src/main/java/org/apache/hudi/common/util/RateLimiter.java b/hudi-common/src/main/java/org/apache/hudi/common/util/RateLimiter.java
@@ -53,19 +53,22 @@ private RateLimiter(int permits, TimeUnit timePeriod) {
   }
 
   public boolean tryAcquire(int numPermits) {
-    if (numPermits > maxPermits) {
-      acquire(maxPermits);
-      return tryAcquire(numPermits - maxPermits);
-    } else {
-      return acquire(numPermits);
+    int remainingPermits = numPermits;
+    while (remainingPermits > 0) {
+      if (remainingPermits > maxPermits) {
+        acquire(maxPermits);
+        remainingPermits -= maxPermits;
+      } else {
+        return acquire(remainingPermits);
+      }
     }
+    return true;
   }
 
   public boolean acquire(int numOps) {
     try {
-      if (!semaphore.tryAcquire(numOps)) {
+      while (!semaphore.tryAcquire(numOps)) {
         Thread.sleep(WAIT_BEFORE_NEXT_ACQUIRE_PERMIT_IN_MS);
-        return acquire(numOps);
       }
       LOG.debug(String.format("acquire permits: %s, maxPremits: %s", numOps, maxPermits));
     } catch (InterruptedException e) {