Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse namespace again instead of using nikic/php-parser #26

Merged
merged 0 commits into from
Nov 30, 2021
Merged

Conversation

simPod
Copy link
Collaborator

@simPod simPod commented Nov 30, 2021

Performance is much better this way

This reverts commit 14bb815

@codecov-commenter
Copy link

Codecov Report

Merging #26 (fd57858) into master (521d25b) will not change coverage.
The diff coverage is 83.33%.

❗ Current head fd57858 differs from pull request most recent head 521d25b. Consider uploading reports for the commit 521d25b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files           2        2           
  Lines          45       45           
=======================================
  Hits           38       38           
  Misses          7        7           
Impacted Files Coverage Δ
src/ClassExtractor.php 88.88% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521d25b...521d25b. Read the comment docs.

@simPod simPod merged commit 9d07daa into master Nov 30, 2021
@simPod simPod deleted the ns branch November 30, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants