Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We use data providers in phpunit that are manually located bellow the test or bellow the set of tests that use it.
Since phpunit v10 requires data providers to be static, the ClassStructure rule would detach them from the actual test resulting in:
Also there has been a lot of discussion in past on how to order these methods.
Proposal
I propose to loosen the rule and sort methods only by visibility. Specifically:
The remaining attributes like
abstract
,final
andstatic
will not be taken into account and left for the user to do whatever he considers the best.