Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify pattern in ValidVariableNameSniff #66

Merged
merged 15 commits into from
Feb 9, 2022
Merged

Allow to specify pattern in ValidVariableNameSniff #66

merged 15 commits into from
Feb 9, 2022

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Feb 3, 2022 •
edited
Loading

@simPod simPod force-pushed the variable-name branch 2 times, most recently from b221f6e to ac2436c Compare February 3, 2022 12:33
@simPod simPod force-pushed the variable-name branch 3 times, most recently from 4b4829d to 4407327 Compare February 3, 2022 13:29
@simPod
Do not juggle with stripping _. Just don't use it for prefixing. We…
278cc68 
… have better ways of defining property visibility nowadays.
@simPod simPod marked this pull request as ready for review February 3, 2022 13:36
@simPod simPod requested review from grongor and baci266 February 4, 2022 13:57
@simPod simPod merged commit 3558e06 into master Feb 9, 2022
@simPod simPod deleted the variable-name branch February 9, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fialamarek fialamarek fialamarek approved these changes

@baci266 baci266 baci266 approved these changes

@grongor grongor Awaiting requested review from grongor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simPod @grongor @baci266 @fialamarek