cdnjs-importer 2.0.0 #13

IonicaBizau · 2015-06-18T13:57:42Z

Relicensed under The KINDLY License.
Generated docs via blah.
New cli interface, via clp. Fixed Use CLP as arguments parser #9.
Create a different branch from master when adding libraries. Fixes Checkout a different branch #12.
Keep only one autoupdate field. Fixed Support import from git repo #11.
Updated dependencies. Fixed Update is-there #8.

$ cdnjs-importer -h
Usage: cdnjs-importer [options]

Options:
  -g, --git-url <git-url>  Your library git url.                   
  -p, --path <path>        The path to your cdnjs local repository.
  -h, --help               Displays this help.                     
  -v, --version            Displays version information.           

Examples:
  cdnjs-importer -g git@github.com:IonicaBizau/gh.js.git # adds gh.js to cdnjs
  cdnjs-importer -g ... -p path/to/cdnjs

The default cdnjs repository location is in ~/cdnjs

Documentation can be found at https://github.com/IonicaBizau/cdnjs-importer

IonicaBizau · 2015-06-18T13:58:34Z

@PeterDaveHello Could you please test it out? 😄

PeterDaveHello · 2015-06-18T14:06:08Z

hmmmmmm ... I am afraid that I can not do it soon, but will do it after 2 weeks if you don't mind, currently working on some very important works, sorry.

IonicaBizau · 2015-07-06T08:03:55Z

but will do it after 2 weeks if you don't mind

@PeterDaveHello So, could you test it out and give me feedback? 😄 I know time passes quickly. ⌛

PeterDaveHello · 2015-07-06T14:57:26Z

oooooooops, 3 more days please ... btw, would you like to move this project to cdnjs organization?

IonicaBizau · 2015-07-06T14:59:54Z

😄

btw, would you like to move this project to cdnjs organization?

@PeterDaveHello Sure! Maybe, can I get a little shiny donation? 😀

PeterDaveHello · 2015-07-06T15:00:40Z

@IonicaBizau What does the donation actually mean here bro?

IonicaBizau · 2015-07-06T15:03:54Z

@PeterDaveHello Some money on PayPal is always welcome! 😸

PeterDaveHello · 2015-07-06T15:07:40Z

Ha, I really hope so I can do, but actually, I don't even get any money from this project yet.
@thomasdavis, will our income from ads export to my account soon?

PeterDaveHello · 2015-07-09T09:49:49Z

cdnjs-importer/bin/cdnjs-importer -g git://github.com/ocombe/ocLazyLoad.git
Will not pass the test

PeterDaveHello · 2015-07-09T09:50:20Z

Can not handle(even let the user know) conflicts, would you like to fix it in this version or not?

IonicaBizau · 2015-07-09T10:47:00Z

cdnjs-importer/bin/cdnjs-importer -g git://github.com/ocombe/ocLazyLoad.git
Will not pass the test

I will check it out.

Can not handle(even let the user know) conflicts, would you like to fix it in this version or not?

It's better to fix it now since this is major release.

IonicaBizau · 2015-07-10T09:24:21Z

@PeterDaveHello Why doesn't the above package pass the test?

PeterDaveHello · 2015-07-10T10:51:38Z

Which one? Do you have its dump?

IonicaBizau · 2015-07-10T10:53:37Z

@PeterDaveHello cdnjs-importer/bin/cdnjs-importer -g git://github.com/ocombe/ocLazyLoad.git -- don't have time to test it out, but having the error I can think where to fix it. 😄

PeterDaveHello · 2015-07-10T11:09:26Z

I can not help without the dump, in fact, all the rules are in cdnjs's repo, you can check it out.

IonicaBizau · 2015-07-16T12:11:24Z

The test error says:

Remove the first 2 spaces of each line and include blank line at end if you copy and paste this example

@PeterDaveHello I don't really understand why this appears -- I added the blank line at the end and removed the 2 spaces on each line, still, it appears. Why?

PeterDaveHello · 2015-07-16T15:14:35Z

How about give me the raw/bump to debug!

IonicaBizau · 2015-07-18T19:07:39Z

Okokok:

·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
···············································································································································································································✗·····················································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
·····································································································································································································································································
······················································································································································································································································               


    oclazyload                                                                                                                                                                                                                                                       
      ✗ oclazyload: format check                                                                                                                                                                                                                                     
        » oclazyload: package.json wrong format, correct one should be like this.                                                                                                                                                                                    
  (Remove the first 2 spaces of each line and include blank line at end if you copy and paste this example)                                                                                                                                                          
  {                                                                                                                                                                                                                                                                  
    "name": "oclazyload",                                                                                                                                                                                                                                            
    "version": "1.0.2",                                                                                                                                                                                                                                              
    "description": "Load modules on demand (lazy load) with angularJS",                                                                                                                                                                                              
    "main": "dist/ocLazyLoad.js",                                                                                                                                                                                                                                    
    "author": "Olivier Combe <olivier.combe@gmail.com>",                                                                                                                                                                                                             
    "license": "MIT",                                                                                                                                                                                                                                                
    "homepage": "https://github.com/ocombe/ocLazyLoad",                                                                                                                                                                                                              
    "directories": {                                                                                                                                                                                                                                                 
      "example": "examples"                                                                                                                                                                                                                                          
    },                                                                                                                                                                                                                                                               
    "repository": {                                                                                                                                                                                                                                                  
      "type": "git",                                                                                                                                                                                                                                                 
      "url": "git://github.com/ocombe/ocLazyLoad.git"                                                                                                                                                                                                                
    },                                                                                                                                                                                                                                                               
    "keywords": [                                                                                                                                                                                                                                                    
      "lazy load",                                                                                                                                                                                                                                                   
      "lazy-load",                                                                                                                                                                                                                                                   
      "load on demand",                                                                                                                                                                                                                                              
      "module",                                                                                                                                                                                                                                                      
      "angular",                                                                                                                                                                                                                                                     
      "angularJS"                                                                                                                                                                                                                                                    
    ],                                                                                                                                                                                                                                                               
    "bugs": {                                                                                                                                                                                                                                                        
      "url": "https://github.com/ocombe/ocLazyLoad/issues"                                                                                                                                                                                                           
    },                                                                                                                                                                                                                                                               
    "npmName": "oclazyload",                                                                                                                                                                                                                                         
    "npmFileMap": [                                                                                                                                                                                                                                                  
      {                                                                                                                                                                                                                                                              
        "basePath": "/dist",                                                                                                                                                                                                                                         
        "files": [                                                                                                                                                                                                                                                   
          "*/"                                                                                                                                                                                                                                                       
        ]                                                                                                                                                                                                                                                            
      }                                                                                                                                                                                                                                                              
    ],                                                                                                                                                                                                                                                               
    "filename": "modules"                                                                                                                                                                                                                                            
  }                                                                                                                                                                                                                                                                  

   // valid-packages-test.js:158                                                                                                                                                                                                                                     
  ✗ Broken » 14077 honored ∙ 1 broken (26.116s)                                                                                                                                                                                                                      
  npm ERR! Test failed.  See above for more details.                                                                                                                                                                                                                 
npm ERR! not ok code 0

PeterDaveHello · 2015-07-18T19:11:49Z

Could you give the dump of package.json?

IonicaBizau · 2015-07-18T19:13:08Z

$ cat ajax/libs/oclazyload/package.json                                                                                                                                                                                                   
{                                                                                                                                                                                                                                                                    
  "name": "oclazyload",                                                                                                                                                                                                                                              
  "version": "1.0.2",                                                                                                                                                                                                                                                
  "description": "Load modules on demand (lazy load) with angularJS",                                                                                                                                                                                                
  "main": "dist/ocLazyLoad.js",                                                                                                                                                                                                                                      
  "author": "Olivier Combe <olivier.combe@gmail.com>",                                                                                                                                                                                                               
  "license": "MIT",                                                                                                                                                                                                                                                  
  "homepage": "https://github.com/ocombe/ocLazyLoad",                                                                                                                                                                                                                
  "directories": {                                                                                                                                                                                                                                                   
    "example": "examples"                                                                                                                                                                                                                                            
  },                                                                                                                                                                                                                                                                 
  "repository": {                                                                                                                                                                                                                                                    
    "type": "git",                                                                                                                                                                                                                                                   
    "url": "git://github.com/ocombe/ocLazyLoad.git"                                                                                                                                                                                                                  
  },                                                                                                                                                                                                                                                                 
  "keywords": [                                                                                                                                                                                                                                                      
    "lazy load",                                                                                                                                                                                                                                                     
    "lazy-load",                                                                                                                                                                                                                                                     
    "load on demand",                                                                                                                                                                                                                                                
    "module",                                                                                                                                                                                                                                                        
    "angular",                                                                                                                                                                                                                                                       
    "angularJS"                                                                                                                                                                                                                                                      
  ],                                                                                                                                                                                                                                                                 
  "bugs": {                                                                                                                                                                                                                                                          
    "url": "https://github.com/ocombe/ocLazyLoad/issues"                                                                                                                                                                                                             
  },                                                                                                                                                                                                                                                                 
  "npmName": "oclazyload",                                                                                                                                                                                                                                           
  "npmFileMap": [                                                                                                                                                                                                                                                    
    {                                                                                                                                                                                                                                                                
      "basePath": "/dist",                                                                                                                                                                                                                                           
      "files": [                                                                                                                                                                                                                                                     
        "**/*"                                                                                                                                                                                                                                                       
      ]                                                                                                                                                                                                                                                              
    }                                                                                                                                                                                                                                                                
  ],                                                                                                                                                                                                                                                                 
  "filename": "modules"                                                                                                                                                                                                                                              
}

PeterDaveHello · 2015-07-18T19:26:13Z

What's its md5 hash? c158f5f8b6375f1599ea86a86e0a158f? 59b6e9b10e03bef47986b9cf1df18adf?

IonicaBizau · 2015-07-20T11:59:57Z

@PeterDaveHello Hmm, how to calculate that hash?

$ md5sum ~/cdnjs/ajax/libs/oclazyload/package.json
3acaff315b09a6d75e6a340f466670dd  /home/ionicabizau/cdnjs/ajax/libs/oclazyload/package.json

PeterDaveHello · 2015-07-20T12:01:47Z

Looks different, so I think you should better upload it to google drive or dropbox or somewhere else to let me download and test it, thanks!

IonicaBizau · 2015-07-20T12:16:13Z

Isn't this enough?

$ cat ~/cdnjs/ajax/libs/oclazyload/package.json                                                                                                   
{
  "name": "oclazyload",
  "version": "1.0.2",
  "description": "Load modules on demand (lazy load) with angularJS",
  "main": "dist/ocLazyLoad.js",
  "author": "Olivier Combe <olivier.combe@gmail.com>",
  "license": "MIT",
  "homepage": "https://github.com/ocombe/ocLazyLoad",
  "directories": {
    "example": "examples"
  },
  "repository": {
    "type": "git",
    "url": "git://github.com/ocombe/ocLazyLoad.git"
  },
  "keywords": [
    "lazy load",
    "lazy-load",
    "load on demand",
    "module",
    "angular",
    "angularJS"
  ],
  "bugs": {
    "url": "https://github.com/ocombe/ocLazyLoad/issues"
  },
  "npmName": "oclazyload",
  "npmFileMap": [
    {
      "basePath": "/dist",
      "files": [
        "**/*"
      ]
    }
  ],
  "filename": "modules"
}

PeterDaveHello · 2015-07-20T12:24:30Z

No is not. You can try to copy and paste, I can't get the same md5.

IonicaBizau · 2015-07-23T06:00:24Z

@PeterDaveHello There you go! ⚡

PeterDaveHello · 2015-07-23T08:46:56Z

hmmmm ... should remove the last blank line.

IonicaBizau · 2015-08-09T11:17:44Z

@PeterDaveHello Pushed a fix to pull first from github/cdnjs/cdnjs and then to add the files. Do you have any idea how to save the file without adding that new line at the end?

It's just a JSON.stringify. On the other side, why is it so important not to have that new line at the end of the file (in cdnjs)?

IonicaBizau · 2015-08-09T11:34:04Z

Actually, it should end with a new line character. Why?

PeterDaveHello · 2015-08-09T11:47:17Z

We use JSON.stringify too, I think JSON.stringify didn't bite, see:

https://github.com/cdnjs/cdnjs/blob/master/auto-update.js#L185

        if (stable.is(version) && semver.gt(version, pkg.version)) {
          pkg.version = version;

          fs.writeFileSync(libPatha, JSON.stringify(pkg, null, 2) + '\n', 'utf8');
        }

https://github.com/cdnjs/autoupdate/blob/master/updaters/git.js#L60

            if(allFiles.length !==0 && stable.is(tag) && semver.gt(tag, package.version)){
              console.log('Updated package.json to version'.green, tag);
              var packagePath = path.normalize(path.join(__dirname, '../../cdnjs', 'ajax', 'libs', package.name, 'package.json')),
                packageJSON = JSON.parse(fs.readFileSync(packagePath, 'utf8'));
              packageJSON.version = tag;
              fs.writeFileSync(packagePath, JSON.stringify(packageJSON, undefined, 2)  + '\n');
            }

We don't have to have a empty new line at the end of file, that doesn't make sense, some coding style even disallow it, and most of the libs don't do that, for examples:
https://github.com/jquery/jquery/blob/master/package.json
https://github.com/uikit/uikit/blob/master/package.json
https://github.com/angular/angular.js/blob/master/package.json
https://github.com/emberjs/ember.js/blob/master/package.json

IonicaBizau · 2015-08-09T11:50:05Z

fs.writeFileSync(libPatha, JSON.stringify(pkg, null, 2) + '\n', 'utf8');

Exactly! So I need to handle that little \n in w-json. Will push a fix soon.

IonicaBizau · 2015-08-09T12:14:48Z

@PeterDaveHello Now it should work. The tests are passing. 😄

PeterDaveHello · 2015-08-09T12:19:48Z

👍

IonicaBizau · 2015-08-09T12:21:53Z

@PeterDaveHello If you like, we can move it in @cdnjs. 🎉 Got stable!

PeterDaveHello · 2015-08-09T15:11:05Z

@IonicaBizau Let's do it. We can discuss the detail on gitter 👍

move test -> example (same as #19)

IonicaBizau · 2015-10-04T11:58:18Z

Hey @PeterDaveHello @Piicksarn @maruilian11! ✨

Could you please test these changes and give me feedback? I'm going to release the new version this week. 🎉

PeterDaveHello · 2015-10-04T22:32:50Z

hmmmm ... I need more time, working on other important issue right now.
I think we can release v2.0.0-betas right now.

IonicaBizau · 2015-10-05T04:25:32Z

@PeterDaveHello Good idea! cdnjs-importer@2.0.0-beta is out. 🎉

PeterDaveHello · 2015-10-05T04:36:46Z

Nice 👍

@ryankirkman: @IonicaBizau wanna post the info about the new version of importer on twitter, would you please help him? I have no permission on it~

IonicaBizau · 2015-10-05T04:37:19Z

@ryankirkman Yeah, an update would be welcome! 😄

ryankirkman · 2015-10-05T07:38:55Z

Certainly gentlemen, here it is: https://twitter.com/cdnjs/status/650938062713688065

Thank you @IonicaBizau !

PeterDaveHello · 2015-10-05T07:40:35Z

@ryankirkman thanks

IonicaBizau · 2015-10-05T07:45:26Z

@ryankirkman @PeterDaveHello Thanks, guys! ✨

Sorry it took so long to release the new version.

PeterDaveHello · 2015-10-05T07:45:59Z

@IonicaBizau no problem!

IonicaBizau mentioned this pull request Jun 25, 2015

Added react-modal@0.2.0 cdnjs/cdnjs#4785

Merged

IonicaBizau mentioned this pull request Aug 10, 2015

[Request] Add flipclock cdnjs/cdnjs#5303

Closed

IonicaBizau added 6 commits September 20, 2015 11:02

Merge pull request #21 from cdnjs/example

cc43a2a

move test -> example (same as #19)

📝

9b1b5b0

Updated the image

6c7bc99

Upgraded dependencies

3f9eaf7

Use abs to normalize the path. Display the computed path value

9142ddb

Fixed the pwd value. Fixed #10.

f12a35f

IonicaBizau added 2 commits October 5, 2015 07:18

Fixed the email address

c276ea3

Generated the docs

453007e

IonicaBizau merged commit 453007e into master Oct 5, 2015

IonicaBizau deleted the new-version branch October 5, 2015 04:25

cdnjs-importer 2.0.0 #13

cdnjs-importer 2.0.0 #13

Conversation

IonicaBizau commented Jun 18, 2015

IonicaBizau commented Jun 18, 2015

PeterDaveHello commented Jun 18, 2015

IonicaBizau commented Jul 6, 2015

PeterDaveHello commented Jul 6, 2015

IonicaBizau commented Jul 6, 2015

PeterDaveHello commented Jul 6, 2015

IonicaBizau commented Jul 6, 2015

PeterDaveHello commented Jul 6, 2015

PeterDaveHello commented Jul 9, 2015

PeterDaveHello commented Jul 9, 2015

IonicaBizau commented Jul 9, 2015

IonicaBizau commented Jul 10, 2015

PeterDaveHello commented Jul 10, 2015

IonicaBizau commented Jul 10, 2015

PeterDaveHello commented Jul 10, 2015

IonicaBizau commented Jul 16, 2015

PeterDaveHello commented Jul 16, 2015

IonicaBizau commented Jul 18, 2015

PeterDaveHello commented Jul 18, 2015

IonicaBizau commented Jul 18, 2015

PeterDaveHello commented Jul 18, 2015

IonicaBizau commented Jul 20, 2015

PeterDaveHello commented Jul 20, 2015

IonicaBizau commented Jul 20, 2015

PeterDaveHello commented Jul 20, 2015

IonicaBizau commented Jul 23, 2015

PeterDaveHello commented Jul 23, 2015

IonicaBizau commented Aug 9, 2015

IonicaBizau commented Aug 9, 2015

PeterDaveHello commented Aug 9, 2015

IonicaBizau commented Aug 9, 2015

IonicaBizau commented Aug 9, 2015

PeterDaveHello commented Aug 9, 2015

IonicaBizau commented Aug 9, 2015

PeterDaveHello commented Aug 9, 2015

IonicaBizau commented Oct 4, 2015

PeterDaveHello commented Oct 4, 2015

IonicaBizau commented Oct 5, 2015

PeterDaveHello commented Oct 5, 2015

IonicaBizau commented Oct 5, 2015

ryankirkman commented Oct 5, 2015

PeterDaveHello commented Oct 5, 2015

IonicaBizau commented Oct 5, 2015

PeterDaveHello commented Oct 5, 2015