Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new speed input step + manual inputs #190

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Conversation

cdrani
Copy link
Owner

@cdrani cdrani commented Nov 29, 2023

Changes

image
  • Step for Slider updated to 0.001 for finer control, though this now comes with a slight delay of 50ms so the speed is not updated too often when user is just sliding around back and forth. Without the delay, Spotify occasionally will sputter and show an alert about loading the song from a local file.
  • Replace the static Track & Global Speed Indicator (originally span) to an input for user manual input of speed values such as 0.982.
  • Update the conversion factor (from 100 to 1000) for the speed value used in the share url. For EX: https://open.spotify.com/track/2w4yylkuKugYjEVhwKc0OD?ch=10-60-982-1, 982 would be the speed of 0.982.

closes #189

@cdrani cdrani merged commit 9ef8ef2 into develop Nov 29, 2023
@cdrani cdrani deleted the feat/speed-inputs branch November 29, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Allow finer grain control of speed/pitch changes
1 participant