Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better snip + loop controls #201

Merged
merged 43 commits into from
Dec 21, 2023
Merged

feat: better snip + loop controls #201

merged 43 commits into from
Dec 21, 2023

Conversation

cdrani
Copy link
Owner

@cdrani cdrani commented Dec 14, 2023

PR improves upon current snip controls:

  1. More precise slider controls (update to 0.01 step for settings milliseconds of snip)
  2. Update currentTime value after ~250ms after slider has not been updated. Instantaneous for manual inputs.
  3. New manual inputs for setting start and end times (again - up to milliseconds of snip). Follows HH:MM:SS:MS notation.
  4. Separate looping logic and icon from Spotify's repeat-1
  5. Add loop icon to popup ui
  6. Add loop option to shortcut keys command
image

closes #192, closes #193

@cdrani cdrani added the enhancement New feature or request label Dec 14, 2023
@cdrani cdrani linked an issue Dec 15, 2023 that may be closed by this pull request
@cdrani cdrani force-pushed the feat/better-snip-controls branch from 9a37705 to f0141b0 Compare December 18, 2023 01:23
@cdrani cdrani force-pushed the feat/better-snip-controls branch from f0141b0 to 3a5e0f5 Compare December 20, 2023 06:06
@cdrani cdrani force-pushed the feat/better-snip-controls branch from 3a5e0f5 to 0e03c9b Compare December 21, 2023 09:45
@cdrani cdrani force-pushed the feat/better-snip-controls branch from 0e03c9b to fd988fa Compare December 21, 2023 18:54
@cdrani cdrani marked this pull request as ready for review December 21, 2023 18:55
@cdrani cdrani changed the title feat: better snip controls feat: better snip + loop controls Dec 21, 2023
@cdrani cdrani merged commit a8a7d4a into develop Dec 21, 2023
@cdrani cdrani deleted the feat/better-snip-controls branch December 21, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Released
1 participant