refactor: add some strong typing in authorization layer code #34
Conversation
| @@ -31,10 +31,6 @@ function loadOptionalEnvVar(envVarName: string): string | undefined { | |||
| } | |||
|
|
|||
| function loadRequiredEnvVar(envVarName: string): string { | |||
| if (process.env.NODE_ENV === "test") { | |||
There was a problem hiding this comment.
Removed because all the configuration variables will now be mocked for all tests. See vitest-setup.ts file.
|
|
||
| const algorithm = "RS256"; |
There was a problem hiding this comment.
With optimization in mind I moved some of the variables out of the introspectToken function as they can be initialized once for all future calls to introspectToken.
| @@ -37,11 +43,22 @@ export async function introspectToken(token: string) { | |||
| "Content-Type": "application/x-www-form-urlencoded", | |||
| }, | |||
| }, | |||
| ) | |||
| .then((res) => res.data) | |||
There was a problem hiding this comment.
👀
Should we reopen the debate about promise chaining vs async await?
https://gcdigital.slack.com/archives/C01GFD150MC/p1711033765657599
There was a problem hiding this comment.
no no, try catch is good, sorry about that :)
| @@ -0,0 +1,17 @@ | |||
| import { vi } from "vitest"; | |||
There was a problem hiding this comment.
This new file will be run before any test is invoked.
craigzour
force-pushed
the
refactor/authorization-middleware
branch
from
18540bf to
eb3edda
Compare
| })); | ||
|
|
||
| vi.mock("node:crypto", () => ({ | ||
| createPrivateKey: vi.fn(), |
There was a problem hiding this comment.
When the introspectToken file is imported in a test file, the private key gets created right away (now that is lives outside of the function).
Because we don't want to have an RSA private key on Github (even if it is not a valid one), we have to mock the createPrivateKey function so that it does not try and fail to parse the ZITADEL_APPLICATION_KEY that is also mocked just above.
Summary | Résumé