Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to form submission crypto configuration #53

Merged
merged 1 commit into from
Sep 13, 2024
Merged

feat: update to form submission crypto configuration #53

merged 1 commit into from
Sep 13, 2024

Conversation

craigzour
Copy link
Contributor

Summary | Résumé

  • Modifies size of iv/nonce value from 16 to 12 bytes to follow recommendation. Even though Javascript would still be able to handle it, .NET would just throw an exception because a 12 bytes value is expected.
  • Modifies the Optimal Asymmetric Encryption Padding from SHA-1 to SHA-256. As @patheard recently said, this will improve the strength of our encryption.

@craigzour craigzour self-assigned this Sep 13, 2024
@craigzour craigzour enabled auto-merge (squash) September 13, 2024 14:13
@craigzour craigzour mentioned this pull request Sep 13, 2024
Merged
@craigzour craigzour merged commit 94e6798 into main Sep 13, 2024
4 checks passed
@craigzour craigzour deleted the feature/update-form-submission-crypto-configuration branch September 13, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patheard patheard patheard approved these changes

@bryan-robitaille bryan-robitaille Awaiting requested review from bryan-robitaille

Assignees

@craigzour craigzour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigzour @patheard