Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add budget component #1979
Add budget component #1979
Changes from 7 commits
7b384f0
3740b5d
bd43137
b97fd05
50861f8
8a223a8
6a5be61
09a5e3c
425d354
9c060da
dd9f1ff
8eaeeb6
a92dc97
a2e2c62
ff540ee
732c45e
d5fa3bf
1978c82
8f26ae6
248b7fa
e41cdd3
c767c70
91ec95b
de4f094
ce2c751
b4da1bc
a3b5df8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
link_href
value is set to#
, which is a placeholder. Ensure this is updated to the correct URL before deploying.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a newline at the end of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a newline at the end of the file to follow best practices and ensure compatibility with various tools and editors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
data-testid
attribute value should be unique. Theremaining-summary-both-limits
value is duplicated on line 408 and line 413. Consider using a unique value for thedata-testid
attribute on line 413.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
data-testid
attribute value is duplicated here. Consider using a unique value for thedata-testid
attribute to avoid potential issues in testing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
<br />
tags for spacing is not recommended as it is not semantic HTML. Consider using CSS for spacing instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function
remaining_messages_summary
is used here without context. Ensure that this function is defined and imported correctly in the template. Additionally, consider passing the parameters in a more descriptive manner, possibly using named parameters for better readability.