Upgraded NewRelic to v10.3.0 #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jimleroyer
commented
Nov 20, 2024
| @@ -16,7 +17,7 @@ | |||
| # Guincorn sets the server type on our app. We don't want to show it in the header in the response. | |||
| gunicorn.SERVER = "Undisclosed" | |||
|
|
|||
| on_aws = os.environ.get("NOTIFY_ENVIRONMENT", "") in [ | |||
There was a problem hiding this comment.
I don't know why we fell back on an empty string instead of the default None value. It seems unnecessary considering the following condition with the AWS env check.
sastels
reviewed
Nov 21, 2024
| @@ -7,7 +9,8 @@ | |||
|
|
|||
| from app.aws.xray.context import NotifyContext | |||
|
|
|||
| newrelic.agent.initialize() # noqa: E402 | |||
There was a problem hiding this comment.
Strange that we weren't giving it an environment before?
There was a problem hiding this comment.
Right, we should have done that before. We didn't always have a newrelic.ini file though. Not having the env passed means that specific config found in the newewlic.ini would be ignored, but the generic section would still be applied.
sastels
approved these changes
Nov 21, 2024
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
Monitor deployment in the staging environment and make sure this is not going in a crash loop with the kubernetes pods.
Release Instructions | Instructions pour le déploiement
Monitor deployment in the staging environment and make sure this is not going in a crash loop with the kubernetes pods.
Reviewer checklist | Liste de vérification du réviseur