Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore engine version changes for AWS Elasticache Redis v6 #143

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

jimleroyer
Copy link
Member

Summary | Résumé

Related to this Trello card.

Ignore Redis engine v6 changes in the Terraform configuration due to this bug. Terraform does not properly support AWS Elasticache Redis V6 and its version auto-increment feature for the time being.

Test instructions | Instructions pour tester la modification

Hmmph... We don't have much choices to deploy multiple times and see how it goes. 😓

Reviewer checklist | Liste de vérification du réviseur

This is a suggested checklist of questions reviewers might ask during their review | Voici une suggestion de liste de vérification comprenant des questions que les réviseurs pourraient poser pendant leur examen :

  • Does this meet a user need? | Est-ce que ça répond à un besoin utilisateur?
  • Is it accessible? | Est-ce que c’est accessible?
  • Is it translated between both offical languages? | Est-ce dans les deux langues officielles?
  • Is the code maintainable? | Est-ce que le code peut être maintenu?
  • Have you tested it? | L’avez-vous testé?
  • Are there automated tests? | Y a-t-il des tests automatisés?
  • Does this cause automated test coverage to drop? | Est-ce que ça entraîne une baisse de la quantité de code couvert par les tests automatisés?
  • Does this break existing functionality? | Est-ce que ça brise une fonctionnalité existante?
  • Should this be split into smaller PRs to decrease change risk? | Est-ce que ça devrait être divisé en de plus petites demandes de tirage (« pull requests ») afin de réduire le risque lié aux modifications?
  • Does this change the privacy policy? | Est-ce que ça entraîne une modification de la politique de confidentialité?
  • Does this introduce any security concerns? | Est-ce que ça introduit des préoccupations liées à la sécurité?
  • Does this significantly alter performance? | Est-ce que ça modifie de façon importante la performance?
  • What is the risk level of using added dependencies? | Quel est le degré de risque d’utiliser des dépendances ajoutées?
  • Should any documentation be updated as a result of this? (i.e. README setup, etc.) | Faudra-t-il mettre à jour la documentation à la suite de ce changement (fichier README, etc.)?

Copy link
Contributor

@AntoineAugusti AntoineAugusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Terraform plan CI job looks good! It refreshed the state and did not try to make a change so let's give it a go

@AntoineAugusti
Copy link
Contributor

Linked to #124 #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants