Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Annual Limit client to add new data around year info #354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jzbahrai
Copy link
Collaborator

@jzbahrai jzbahrai commented Feb 12, 2025

Summary | Résumé

Added year to date information in the annual limit client

        notifications_v2: {
            sms_delivered_today: int,
            email_delivered_today: int,
            sms_failed_today: int,
            email_failed_today: int,
            total_sms_fiscal_year_to_yesterday: int,
            total_email_fiscal_year_to_yesterday: int,
        }

Code is written to be backwards compatible

Related Issues | Cartes liées

https://app.zenhub.com/workspaces/notify-planning-614b3ad91bc2030015ed22f5/issues/gh/cds-snc/notification-planning/1767

Test instructions | Instructions pour tester la modification

TODO: Fill in test instructions for the reviewer.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@jzbahrai jzbahrai changed the title Edited redis client Edit Annual Limit client to add new data around year info Feb 12, 2025
@jzbahrai jzbahrai requested a review from whabanks February 13, 2025 14:12
@jzbahrai jzbahrai force-pushed the update-redis-client branch from c1ac86e to 0aefd8e Compare February 13, 2025 14:37
Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just want to clarify what our migration plan is. Are we running a script to migrate existing key values over to the v2 structure? Or are we just waiting for that to occur naturally over time?

@jzbahrai
Copy link
Collaborator Author

@whabanks the transition plan will be to just naturally wait for the new api/admin code to replace the old keys/ no script should be necessary

@jzbahrai jzbahrai force-pushed the update-redis-client branch from e4b0533 to 7724771 Compare February 14, 2025 18:54
@jzbahrai jzbahrai force-pushed the update-redis-client branch from 7724771 to 818d6f5 Compare February 14, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants