Adding MyPy to CI #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcmurtry
commented
Jul 9, 2021
| ], | ||
| [], | ||
| ) | ||
| invalid_local_phone_numbers = [ |
There was a problem hiding this comment.
I executed this statement and found that it was just a really over-complicated way of building a list like this:
[("1234", "Not a valid local number"), ("2345", "Not a valid local number"), ...]
So I replaced it, verified that the new statement == the old, and the type error went away.
There was a problem hiding this comment.
Thanks for coming back on this; the code is much clearer to me with this new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR adds the MyPy static type checker to notification-utils, similar to what we have done for notification-admin (cds-snc/notification-admin#1055) and notification-api (cds-snc/notification-api#1320).